Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable detail panel link #3070

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Disable detail panel link #3070

merged 1 commit into from
Feb 16, 2018

Conversation

rbruggem
Copy link
Contributor

@rbruggem rbruggem commented Feb 15, 2018 •
edited by rade
Loading

The link is disabled if the monitor flag is not true.
If Weave Cloud runs without Monitor, the link is dead. The flag allows to pass Weave Cloud's Monitor state down to Scope.

Disable detail panel link
7225546 
The link is disabled if the `monitor` flag is not true.
If Weave Cloud runs without Monitor, the link is dead. The flag allows to pass Weave Cloud's Monitor state down to Scope.
@rbruggem rbruggem requested a review from rndstr February 15, 2018 18:21
rndstr
rndstr approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rbruggem rbruggem merged commit 8bb79f0 into master Feb 16, 2018
@rbruggem rbruggem deleted the monitor-flag branch February 16, 2018 11:07
@leth
Copy link
Contributor

leth commented Feb 16, 2018

Hide deep links to unobtainable product areas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndstr rndstr rndstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbruggem @leth @rndstr